Skip to content
Snippets Groups Projects

Draft: Pebble timeline support

Open Ruben De Smet requested to merge rubdos/kuri:pebble-timeline into master
6 unresolved threads

Currently untested, because my sfdk is apparently broken. Will update!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • I just skimmed over the small changes and need some time for a thorough review.

      In general, having this feature merged is not a problem, but keeping it functional will be since I cannot easily test it. Can I ping you to test a pre-release once this is merged an new releases are imminent?

    • I just skimmed over the small changes and need some time for a thorough review.

      No problem, let me know what you think needs changing.

      Can I ping you to test a pre-release once this is merged an new releases are imminent?

      Absolutely. I might not be the quickest to respond on Gitlab, but feel free to ping me on Matrix/IRC/email/Signal! I'll happily go on a walk through the city to test it :-)

      I've pushed two fixups; if they look good to you, I'll sqaush them into their originating commits.

    • Please register or sign in to reply
  • Ruben De Smet added 2 commits

    added 2 commits

    • 98d3045d - fixup! Correct unit conversions
    • 47bd2b32 - fixup! Actually trigger the Pebble updates

    Compare with previous version

  • Ruben De Smet marked this merge request as draft from rubdos/kuri@98d3045d

    marked this merge request as draft from rubdos/kuri@98d3045d

  • 53 53 }
    54 54 }
    55 55
    56 PebbleManager {
    57 id: pebbleManager
    58 }
    59
    60 function updateActivityType(type, name) {
    61 pebbleManager.activityType = type;
    62 pebbleManager.activityName = name;
    63 }
  • 53 53 }
    54 54 }
    55 55
    56 PebbleManager {
    57 id: pebbleManager
    58 }
  • 180 189 onTriggered: {
    181 190 timeView.update();
    182 191
    192 pebbleManager.updatePebbles();
  • 63 63
    64 64 KURI_RO_PROPERTY(bool, recording, false);
    65 65 KURI_RO_PROPERTY_WITH_DEFAULT_IMPL(bool, pausing, false);
    66 KURI_RO_PROPERTY_WITH_DEFAULT_IMPL(QString, activityType, "walking");
    • This value can be accessed from QML with Settings.workoutType. It seems I forgot to rename the property to Settings.activityType. It's now renamed on master. Please rebase and use Settings.activityType instead of adding a new property.

    • Please register or sign in to reply
  • Sorry for the long delay. I hope you are still interested in bringing this upstream.

  • Mathias »Bob« Kraus left review comments

    left review comments

  • Please register or sign in to reply
    Loading