refactor: calculate income tax slab method in salary slip [frappe] PR#4575

From: https://github.com/frappe/hrms/pull/4575
Date: 2026-05-25 15:55:39+05:30

  • chore: function name clean up
  • chore: initialise empty dict chore: fix flaky test
  • chore: clean up after conflicts
  • test: integration test for income tax without marginal relief
  • test: test calculate income tax methods
  • chore: wrap exception error in str()
  • refactor: calculate income tax slab method in salary slip to inject surcharge calculation with marginal relief for india region



Diagnostics

pre-commit failed for source commit: 32f1307b14a0c69be5d864e92b71ce2781f86a99
hrms/hr/doctype/attendance_request/test_attendance_request.py:186:30: F821 Undefined name `is_holiday`
Found 1 error.



Checkout instructions
# Checkout locally
git fetch upstream
git switch ft-pr-4575

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-4575

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports

Loading