fix: default permission for HR roles by iamkhanraheel [frappe] PR#4264

Bot Dokosrequested to merge
ft-pr-4264 into develop

From: https://github.com/frappe/hrms/pull/4264
Date: 2026-04-16 17:20:51+05:30

  • fix: remove unnecessary access for manufacturing & account user roles
  • test(expense_claim): add repost doctype in repost_allowed_types as Repost Accounting Ledger Settings is merged into accounts settings
  • fix: add default perms for HR user & remove unnecessary perms
  • patch: add default HR roles permissions
  • fix: add update_permission_property to update perm in existing custom docperm
  • fix: remove unwanted import
  • fix: deault perm for HR manager & HR user
  • fix: default perm for HR manager & HR user
  • fix: default permission for HR manager role & add custom docperm for doctypes in frappe app
  • fix: default permission for HR User role


Diagnostics

pre-commit failed for source commit: c6e46fc0eb17001f56a00d1364e5ac3d6f49e7dc
hrms/setup.py:24:2: F821 Undefined name `setup_repost_defaults`
Found 1 error.


pre-commit failed for source commit: 4a8fff886cdce0068310fff92f8d79bf54bfb4b5
hrms/setup.py:24:2: F821 Undefined name `setup_repost_defaults`
Found 1 error.


pre-commit failed for source commit: 3e8274a8ff2c16cafe0d94cb52596d622ff17d71
hrms/setup.py:23:2: F821 Undefined name `setup_repost_defaults`
Found 1 error.


pre-commit failed for source commit: 37158b65ffaec8a2e485676fc084c262c6e94167
hrms/setup.py:22:2: F821 Undefined name `setup_repost_defaults`
Found 1 error.




Suspicious changes found (Dokos Only / dokos):
* 61b95eeabbdeab0f5bb7f7ebc54d17a484a5a2e5 patch: add default HR roles permissions
```diff

```


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-4264

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-4264

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports