feat: filter department and branch dropdowns by company in Monthly Attendance Sheet by abishektridots-ctrl [frappe] PR#4343
From: https://github.com/frappe/hrms/pull/4343
Date: 2026-04-08 10:47:12+05:30
- fix: missed to import to create test_company
- test: added additional test case for filter department and branch dropdowns by company in Monthly Attendance Sheet.
- feat: filter department and branch dropdowns by company in Monthly Attendance Sheet The Department and Branch filter dropdowns in the Monthly Attendance Sheet now scope their options to the selected Company, consistent with how the Employee filter already behaves. This makes it easier to find the right department or branch when working with large multi-company setups.
Diagnostics
pre-commit failed for source commit: a0c2ba562bed16cc7fedfc779d053d708b1d7dc3
hrms/hr/report/monthly_attendance_sheet/test_monthly_attendance_sheet.py:525:11: F821 Undefined name `create_department`
hrms/hr/report/monthly_attendance_sheet/test_monthly_attendance_sheet.py:526:11: F821 Undefined name `create_department`
hrms/hr/report/monthly_attendance_sheet/test_monthly_attendance_sheet.py:583:10: F821 Undefined name `create_department`
hrms/hr/report/monthly_attendance_sheet/test_monthly_attendance_sheet.py:601:15: F821 Undefined name `create_department`
Found 4 errors.Checkout instructions
# Checkout locally
git fetch upstream
git switch ft-pr-4343
# Alternatively, re-take the changes
git switch develop
ft take ft-pr-4343
# Make changes then rebase
git rebase -i develop
# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue
# Force-push changes
git push --force-with-lease