fix: force type hint on whilelisted methods by asmitahase [frappe] PR#4253

Bot Dokosrequested to merge
ft-pr-4253 into develop

From: https://github.com/frappe/hrms/pull/4253
Date: 2026-03-23 12:28:10+05:30

  • fix: flaky test
  • fix: correct type hint
  • fix: force type hints on whitelisted methods
  • fix: remaining missing type hints


Diagnostics 

pre-commit failed for source commit: 52fb6346436804b77f634f7ed5f8c8d73e4ebfcb
[WARNING] top-level `default_stages` uses deprecated stage names (commit) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks` will fix this.  if it does not -- consider reporting an issue to that repo.

1 file reformatted, 8 files left unchanged


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-4253

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-4253

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports