refactor: cleanup interviews by krantheman [frappe] PR#924

From: https://github.com/frappe/hrms/pull/924
Date: 2024-01-01 10:14:10+05:30

• Merge pull request #924 from krantheman/cleanup-interviews
• chore: allow updating interview detail on submission
• chore: remove unused col break
• test(APIs): get_feedback & get_skill_wise_average_rating
• fix: use left join in interview feedback query to fetch feedback from non-employee users
• fix: move Reschedule Interview to Actions
• fix: notify update after updating average rating in interview
• feat: set current interview timings as default while rescheduling
• chore: cleanup templates
• feat: show hover message for disabled feedback submission
• test: fix interview tests
• fix: don't break whitelisted API
• fix: run feedback functions serially
• perf: remove lazy-loaded bundles from app include js
• fix: move whitelisted getter functions outside class
• refactor: move fetch fields to fetch_from config, cleanup js controller
• fix: fetching applicable interviewers for interview & feedback
• refactor: retain interview detail doctype
• chore: fix formatting
• test: fix Interviewers
• chore: convert map to list comprehension
• chore: merge with develop and fix conflicts
• refactor: use Table instead of Table MultiSelect for Interviewers
• refactor: consider Interviewers selected in Interview rather than from Interview Round
• feat: add Interviewers field which automatically fetches interviewers based on Interview Round
• fix(circular_progress): file name typo
• chore: rename performance_feedback_history to performance_feedback
• refactor: clean up feedback_history context
• fix(Appraisal): Employee Performance Feedback link
• refactor: use common feedback_history and feedback_summary
• refactor: performance feedback summary
• fix: font size and spacing
• style: change rating colors to gray
• chore: improve readability
• chore: convert spaces to tabs ...again
• fix: Feedback Summary subtext
• chore: remove unused import
• fix: rounding
• fix: No feedback message
• fix: Feedback rendering of new Interviews
• refactor: better querying
• chore: delete redundant doctype Interview Detail
• test: clean up instances of interview_detail
• refactor: clean up interview_details
• feat: update interview average rating on submitting feedback
• refactor: disable Submit Feedback for unauthorized users
• fix: circular progress size
• feat: consider colors for ratings between 0 and 1
• feat: use circular progress bar for skills
• refactor: get appllicable interviewers
• feat: dynamic circular progress bar
• feat: add circular progress bar
• refactor: clean up feedback summary
• feat: add individual ratings
• refactor: calculate reviews per rating based on user average rating
• feat: add ratings summary
• feat: pull feedback data from server
• feat: add Feedback Tab
• refactor(Interview Round): make Interview Type optional

---

Diagnostics

pre-commit failed for source commit: 5314b3801cd2d5eec20858c804c6dd9ddadbffdb
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing hrms/hr/doctype/interview_feedback/interview_feedback.py


pre-commit failed for source commit: b793e93b56c5d560f1a87c1e800b6928dead55f6
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:10:1: F401 'frappe.utils.flt' imported but unused


pre-commit failed for source commit: 837c1c1cf79d48980b472501507c2fc0a8701f00
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/test_interview.py:159:58: B006 Do not use mutable data structures for argument defaults.  They are created during function definition time. All calls to the function reuse this one instance of that data structure, persisting changes between them.


pre-commit failed for source commit: 4b5d6b2906c979ecbfe73d0111624a366ad6961e
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:11:1: F401 'frappe.utils.flt' imported but unused
hrms/hr/doctype/interview/interview.py:158:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:211:9: F821 undefined name 'cint'


pre-commit failed for source commit: 0c8c05ad6a3021d3a3ae18f39be8b9424fd8503d
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:158:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:211:9: F821 undefined name 'cint'


pre-commit failed for source commit: 4dde7fed16fb464e99de661e907e499db371d58e
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:158:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:211:9: F821 undefined name 'cint'


pre-commit failed for source commit: 79cf233344453805c49c02c1fdc0ac85da21764e
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:158:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:211:9: F821 undefined name 'cint'


pre-commit failed for source commit: f7990cfea6089cc19b32b0e139101c875d30ba9f
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:156:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:209:9: F821 undefined name 'cint'


Cleaning files from denylist:
 .github/helper/install.sh              |  53 +++++++++++++
 .github/workflows/ci.yml               | 136 +++++++++++++++++++++++++++++++++
 .github/workflows/initiate_release.yml |  32 ++++++++
 .mergify.yml                           |  70 +++++++++++++++++
 4 files changed, 291 insertions(+)


pre-commit failed for source commit: 0ff94289cd53513b18ff88dd8e257aadc89bccee
Trim Trailing Whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing hrms/hr/doctype/expense_claim/expense_claim.js

flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/employee_advance/employee_advance.py:14:1: F401 'hrms' imported but unused
hrms/hr/doctype/employee_checkin/test_employee_checkin.py:19:1: F401 'erpnext.setup.doctype.holiday_list.test_holiday_list.set_holiday_list' imported but unused
hrms/hr/doctype/employee_checkin/test_employee_checkin.py:26:1: F401 'hrms.hr.doctype.leave_application.test_leave_application.get_first_sunday' imported but unused
hrms/hr/doctype/employee_checkin/test_employee_checkin.py:493:33: B008 Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
hrms/hr/doctype/expense_claim/expense_claim.py:16:1: F401 'hrms' imported but unused
hrms/hr/doctype/expense_claim/test_expense_claim.py:5:1: F401 'frappe.tests.utils.change_settings' imported but unused
hrms/hr/doctype/leave_application/leave_application.py:28:1: F401 'hrms' imported but unused
hrms/hr/doctype/shift_type/test_shift_type.py:494:3: F401 'hrms.hr.doctype.employee_checkin.test_employee_checkin.make_checkin' imported but unused
hrms/payroll/doctype/payroll_entry/test_payroll_entry.py:4:1: F401 'dateutil.relativedelta.relativedelta' imported but unused
hrms/payroll/doctype/payroll_entry/test_payroll_entry.py:11:1: F401 'erpnext.accounts.utils.get_fiscal_year' imported but unused
hrms/payroll/doctype/payroll_entry/test_payroll_entry.py:11:1: F401 'erpnext.accounts.utils.getdate' imported but unused
hrms/payroll/doctype/payroll_entry/test_payroll_entry.py:35:1: F401 'hrms.payroll.doctype.salary_structure.test_salary_structure.create_salary_structure_assignment' imported but unused
hrms/payroll/doctype/salary_structure/test_salary_structure.py:166:11: B008 Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
hrms/payroll/doctype/salary_structure/test_salary_structure.py:228:11: B008 Do not perform function calls in argument defaults.  The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call.  If this is intended, assign the function call to a module-level variable and use that variable as a default value.
hrms/utils/__init__.py:50:1: F811 redefinition of unused 'generate_date_range' from line 38


pre-commit failed for source commit: 3af0ccbefacff1fcbf74fda36670281f7b03935d
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:156:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:209:9: F821 undefined name 'cint'


pre-commit failed for source commit: 378857d0e0835c160f0479e96c22cc332be7b9bd
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/test_interview.py:161:58: B006 Do not use mutable data structures for argument defaults.  They are created during function definition time. All calls to the function reuse this one instance of that data structure, persisting changes between them.


pre-commit failed for source commit: 2917a4693b6d121c26beb9fe717d6e09d3990bcc
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:163:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:216:9: F821 undefined name 'cint'


pre-commit failed for source commit: 7bcd3a2bc58ec43fb6bfcbd617f3dcf96df7b12c
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:194:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:247:9: F821 undefined name 'cint'


pre-commit failed for source commit: 501a41b8cd51c4c8b88f94127aafc778074a4436
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:194:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:247:9: F821 undefined name 'cint'


pre-commit failed for source commit: fe0f9cdbee06b007698c826f104986148f279239
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/attendance_request/test_attendance_request.py:15:1: F401 'hrms.tests.test_utils.get_first_sunday' imported but unused
hrms/hr/doctype/interview/interview.py:194:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:247:9: F821 undefined name 'cint'


pre-commit failed for source commit: e48a0c5fb10021cc0ae198c7fa1ccd232f4571b2
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:200:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:253:9: F821 undefined name 'cint'


pre-commit failed for source commit: 285c2a2673cc199908fb9e82f6ae706005e3ebff
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:200:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:253:9: F821 undefined name 'cint'


pre-commit failed for source commit: 7171f5060d2d992b128082883944a945f38daaaf
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:200:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:253:9: F821 undefined name 'cint'


pre-commit failed for source commit: 3309c6ba24ff2ab117b64e873e9afc1e8def3727
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

hrms/hr/doctype/interview/interview.py:201:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/interview.py:254:9: F821 undefined name 'cint'
hrms/hr/doctype/interview/test_interview.py:60:3: F821 undefined name 'change_settings'
hrms/hr/doctype/interview/test_interview.py:81:3: F821 undefined name 'change_settings'




Suspicious changes found (dokos|telemetry|shipping_rule|capture_doc):
  850711c4d80be2147ecd9b8f0dfe345998f7d040 chore: merge with develop and fix conflicts

---

Checkout instructions

# Checkout locally
git fetch upstream
git switch ft-pr-924

# Make changes then rebase
git rebase -i upstream/develop --reapply-cherry-picks

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

added bot::forktool label

added 58 commits

• a4f39ce4...d9142596 - 48 earlier commits
• db231d1c - feat: show hover message for disabled feedback submission
• fd9af484 - chore: cleanup templates
• 3db80722 - feat: set current interview timings as default while rescheduling
• c1636b29 - fix: notify update after updating average rating in interview
• 21aa6ee1 - fix: move Reschedule Interview to Actions
• cb5fd235 - fix: use left join in interview feedback query to fetch feedback from non-employee users
• 453aece3 - test(APIs): `get_feedback` & `get_skill_wise_average_rating`
• 278f587a - chore: remove unused col break
• 57d34e2b - chore: allow updating interview detail on submission
• a6a2f3ce - Merge pull request #924 from krantheman/cleanup-interviews

Compare with previous version

added 1 commit

• 679ef652 - fix: missing import

Compare with previous version

approved this merge request

merged

mentioned in commit 9a4e51ed

assigned to @chdecultot