Skip to content

feat: editable purchase invoice by GursheenK [frappe] PR#37194

Bot Dokos requested to merge ft-pr-37194 into develop

From: https://github.com/frappe/erpnext/pull/37194
Date: 2023-09-26 16:46:11+05:30

  • Merge pull request #37194 from GursheenK/editable-purchase-invoice
  • refactor: remove references in repost doctypes upon parent doc delet
  • fix: validation for si
  • fix: call validate before setting repost flag
  • fix: do not run bg job for single doc
  • refactor: remove repeated validation for voucher
  • refactor: use repost accounting legder
  • refactor: remove unused method
  • test: reposted acc entries for pi
  • fix: linting issues
  • feat: allow repost for pi
  • feat: add repost btn in invoice
  • refactor: move reposting logic to common controller
  • feat: allow on submit fields


Diagnostics

pre-commit failed for source commit: 68effd93bdb1a91a8625d983cd9b8afeb7b1eb3b
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/accounts/doctype/sales_invoice/sales_invoice.py:1031:5: F821 undefined name 'update_outstanding_amt'


pre-commit failed for source commit: c66c4385759b25243f946b708055bccc12561809
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py:209:3: B017 `assertRaises(Exception)` and `pytest.raises(Exception)` should be considered evil. They can lead to your test passing even if the code being tested is never executed due to a typo. Assert for a more specific exception (builtin or custom), or use `assertRaisesRegex` (if using `assertRaises`), or add the `match` keyword argument (if using `pytest.raises`), or use the context manager form with a target.


pre-commit failed for source commit: ba7212c98b81a43e5f63d010eadf99635c95e349
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/accounts/doctype/sales_invoice/sales_invoice.py:1020:5: F821 undefined name 'update_outstanding_amt'


pre-commit failed for source commit: a856091ff4756462b6cf0f02493f6fb6ddf59921
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/accounts/doctype/sales_invoice/sales_invoice.py:1007:5: F821 undefined name 'update_outstanding_amt'


pre-commit failed for source commit: 61c6ebbb95b0e7ecbb86312646fe862b9a471d95
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/accounts/doctype/sales_invoice/sales_invoice.py:1016:5: F821 undefined name 'update_outstanding_amt'


pre-commit failed for source commit: 796cc0915a3a091829644c54e68c6a04c3c9c19a
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/controllers/accounts_controller.py:275:19: F821 undefined name 'repost_doctypes'
erpnext/controllers/accounts_controller.py:302:2: F811 redefinition of unused 'on_trash' from line 271
erpnext/controllers/accounts_controller.py:3376:1: F811 redefinition of unused 'validate_regional' from line 3371


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-37194

# Make changes then rebase
git rebase -i upstream/develop --reapply-cherry-picks

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports