Skip to content

refactor: Bank Reconciliation Tool APIs by marination [frappe] PR#36893

Bot Dokos requested to merge ft-pr-36893 into develop

From: https://github.com/frappe/erpnext/pull/36893
Date: 2023-09-15 14:44:07+05:30

  • test: bank reconciliation API methods
  • chore: Convert db.sql to QB queries
  • fix: Remove get_matching_vouchers_for_bank_reconciliation
  • refactor: verbosity in get_linked_payments result
  • refactor: auto_reconcile_vouchers


Diagnostics

pre-commit failed for source commit: 480903e3f4f458d97416069b28f84281802cc4e1
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:5:1: F401 'unittest' imported but unused
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:16:27: F821 undefined name 'FrappeTestCase'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:26:3: F821 undefined name 'make_pos_profile'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:28:3: F821 undefined name 'add_vouchers'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:36:21: F821 undefined name 'get_linked_payments'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:40:12: F821 undefined name 'utils'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:51:14: F821 undefined name 'json'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:60:3: F821 undefined name 'reconcile_vouchers'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:82:21: F821 undefined name 'get_linked_payments'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:86:12: F821 undefined name 'utils'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:97:14: F821 undefined name 'json'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:106:3: F821 undefined name 'reconcile_vouchers'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:113:14: F821 undefined name 'json'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:124:4: F821 undefined name 'reconcile_vouchers'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:136:14: F821 undefined name 'json'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:145:3: F821 undefined name 'reconcile_vouchers'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:155:3: F821 undefined name 'if_lending_app_installed'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:180:21: F821 undefined name 'create_loan_and_repayment'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:182:21: F821 undefined name 'get_linked_payments'
erpnext/accounts/doctype/bank_transaction/test_bank_transaction.py:186:2: F821 undefined name 'if_lending_app_installed'


pre-commit failed for source commit: 2be025311a52ee620e17c388241e67174086599a
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/accounts/doctype/bank_reconciliation_tool/test_bank_reconciliation_tool.py:4:1: F401 'unittest' imported but unused
erpnext/accounts/doctype/bank_reconciliation_tool/test_bank_reconciliation_tool.py:8:1: F401 'frappe.tests.utils.change_settings' imported but unused
erpnext/accounts/doctype/bank_reconciliation_tool/test_bank_reconciliation_tool.py:9:1: F401 'frappe.utils.flt' imported but unused
erpnext/accounts/doctype/bank_reconciliation_tool/test_bank_reconciliation_tool.py:9:1: F401 'frappe.utils.getdate' imported but unused


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-36893

# Make changes then rebase
git rebase -i upstream/develop --reapply-cherry-picks

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports