Skip to content

RitvikSardana/develop-ritvik-POS-runtime-effect [frappe] PR#36492

Bot Dokos requested to merge ft-pr-36492 into develop

See https://github.com/frappe/erpnext/pull/36492

Date: 2023-08-17T10:54:48+05:30

  • Merge pull request #36492 from RitvikSardana/develop-ritvik-POS-runtime-effect
  • fix: test_serial_no_case_1 test case works
  • chore: code clean up
  • fix: get_items call improved
  • fix: now time set in closing POS
  • fix: added test for runtime effect
  • fix: batched items method giving wrong quantity, so changed it back to previous way
  • fix: batched items in POS
  • fix: POS Runtime Effect completed
  • fix: fixed SABB error
  • fix: added code for batched items in POS


Diagnostics

flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/accounts/doctype/pos_closing_entry/test_pos_closing_entry.py:7:1: F401 'frappe.utils.nowdate' imported but unused


pre-commit failed for source commit: 68df3f9729940b2f241379e85e20ac9fb8f182ec
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/accounts/doctype/pos_closing_entry/test_pos_closing_entry.py:7:1: F401 'frappe.utils.nowdate' imported but unused


pre-commit failed for source commit: d4cc9daca1ac4ebe56828434181936f30e579c13
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

erpnext/accounts/doctype/pos_closing_entry/test_pos_closing_entry.py:7:1: F401 'frappe.utils.nowdate' imported but unused


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-36492

# Make changes then rebase
git rebase -i upstream/develop --reapply-cherry-picks

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports