Draft: ci: add prettier to pre-commit by barredterra [frappe] PR#40206
From: https://github.com/frappe/erpnext/pull/40206
Date: 2024-03-10 20:01:49+05:30
- Merge pull request #40206 from barredterra/bulk-format-js
- chore: update blame ignore
- style: format js files
- ci: add prettier to pre-commit
Diagnostics
Conflicts detected for source commit: ec74a5e56617bbd76ac402451468fd4668af543d
- DU commitlint.config.js
- DU erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.js
- DU erpnext/accounts/doctype/bank_statement_import/bank_statement_import.js
- DU erpnext/accounts/doctype/bank_statement_import/bank_statement_import_list.js
- DU erpnext/accounts/doctype/cashier_closing/cashier_closing.js
- DU erpnext/assets/doctype/asset_shift_allocation/asset_shift_allocation.js
- DU erpnext/projects/doctype/project/project_timesheet.js
- DU erpnext/public/js/bank_reconciliation_tool/data_table_manager.js
- DU erpnext/public/js/bank_reconciliation_tool/dialog_manager.js
- DU erpnext/public/js/bank_reconciliation_tool/number_card.js
- DU erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.js
- DU erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record_list.js
Cleaning files from denylist:
commitlint.config.js | 13 +++++++++++++
1 file changed, 13 insertions(+)
pre-commit failed for source commit: ec74a5e56617bbd76ac402451468fd4668af543d
prettier.................................................................Failed
- hook id: prettier
- exit code: 2
- files were modified by this hook
erpnext/accounts/doctype/journal_entry/journal_entry.js
erpnext/public/js/projects/timer.js
erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.js
erpnext/stock/report/delivery_note_trends/delivery_note_trends.js
erpnext/quality_management/doctype/quality_review/quality_review.js
erpnext/public/js/utils/sales_common.js
erpnext/stock/report/stock_and_account_value_comparison/stock_and_account_value_comparison.js
erpnext/stock/report/purchase_receipt_trends/purchase_receipt_trends.js
erpnext/public/js/telephony.js
erpnext/public/js/payment/payments.js
erpnext/manufacturing/doctype/work_order/work_order.js
erpnext/stock/doctype/delivery_trip/delivery_trip.js
[error] erpnext/accounts/doctype/subscription/subscription.js: SyntaxError: Unexpected token, expected "," (123:3)
[error] 121 | });
[error] 122 | }
[error] > 123 | })
[error] | ^
[error] 124 | dialog.show()
[error] 125 | },
[error] 126 |
erpnext/public/js/utils.js
[error] erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js: SyntaxError: Unexpected token (43:1)
[error] 41 | }
[error] 42 | },
[error] > 43 | });
[error] | ^
[error] 44 |
[error] 45 | erpnext.integrations.plaidLink = class plaidLink {
[error] 46 | constructor(parent) {
erpnext/accounts/doctype/bank_account/bank_account.js
erpnext/accounts/doctype/payment_entry/payment_entry.js
erpnext/public/js/financial_statements.js
erpnext/stock/doctype/delivery_note/delivery_note.js
erpnext/assets/doctype/asset/asset.js
erpnext/accounts/doctype/bank/bank.js
[error] erpnext/accounts/doctype/pos_closing_entry/pos_closing_entry.js: SyntaxError: Unexpected token (159:3)
[error] 157 | ]);
[error] 158 | frappe.dom.unfreeze();
[error] > 159 | },
[error] | ^
[error] 160 | });
[error] 161 |
[error] 162 | frappe.ui.form.on("POS Closing Entry Detail", {
erpnext/selling/page/point_of_sale/point_of_sale.js
erpnext/public/js/help_links.js
[error] erpnext/support/doctype/issue/issue.js: SyntaxError: Unexpected token, expected "," (6:9)
[error] 4 | },
[error] 5 |
[error] > 6 | frappe.db.get_value(
[error] | ^
[error] 7 | "Support Settings",
[error] 8 | { name: "Support Settings" },
[error] 9 | ["allow_resetting_service_level_agreement", "track_service_level_agreement"],
erpnext/crm/doctype/opportunity/opportunity.js
erpnext/manufacturing/doctype/production_plan/production_plan.js
erpnext/manufacturing/doctype/workstation_type/workstation_type.js
[error] erpnext/public/js/event.js: SyntaxError: Unexpected token (89:2)
[error] 87 | __("Add Participants")
[error] 88 | );
[error] > 89 | },
[error] | ^
[error] 90 | });
[error] 91 |
erpnext/selling/page/point_of_sale/pos_item_details.js
erpnext/telephony/doctype/incoming_call_settings/incoming_call_settings.js
erpnext/selling/doctype/customer/customer.js
erpnext/accounts/doctype/payment_order/payment_order.js
erpnext/selling/page/point_of_sale/pos_controller.js
[error] erpnext/stock/doctype/purchase_receipt/purchase_receipt_list.js: SyntaxError: Unexpected token (40:19)
[error] 38 | });
[error] 39 |
[error] > 40 | onload: function (listview) {
[error] | ^
[error] 41 | listview.page.add_action_item(__("Purchase Invoice"), () => {
[error] 42 | erpnext.bulk_transaction_processing.create(listview, "Purchase Receipt", "Purchase Invoice");
[error] 43 | });
erpnext/accounts/doctype/journal_entry/journal_entry_list.js
erpnext/accounts/doctype/payment_request/payment_request.js
erpnext/selling/doctype/customer/customer_list.js
erpnext/stock/dashboard/item_dashboard.js
erpnext/accounts/doctype/purchase_invoice/purchase_invoice.js
erpnext/public/js/stock_analytics.js
erpnext/selling/page/point_of_sale/pos_past_order_summary.js
erpnext/accounts/doctype/sales_invoice/sales_invoice.js
erpnext/manufacturing/report/bom_stock_report/bom_stock_report.js
[error] erpnext/accounts/doctype/bank_transaction/bank_transaction.js: SyntaxError: Unexpected token (126:5)
[error] 124 | });
[error] 125 | break;
[error] > 126 | case "Purchase Invoice":
[error] | ^
[error] 127 | frappe.db.get_value(row.payment_document, row.payment_entry, ["is_return", "supplier", "due_date"], r => {
[error] 128 | frappe.model.set_value(cdt, cdn, "payment_type", r.is_return ? "Debit": "Credit");
[error] 129 | r&&r.supplier&&frappe.model.set_value(cdt, cdn, "party", r.supplier);
erpnext/public/js/erpnext.bundle.js
erpnext/stock/doctype/stock_entry/stock_entry.js
erpnext/selling/report/quotation_trends/quotation_trends.js
erpnext/public/js/conf.js
erpnext/accounts/doctype/chart_of_accounts_importer/chart_of_accounts_importer.js
erpnext/stock/doctype/item/item.js
[error] erpnext/projects/doctype/task/task.js: SyntaxError: Unexpected token, expected "," (17:6)
[error] 15 | },
[error] 16 |
[error] > 17 | frm.fields_dict.project.get_query = function() {
[error] | ^
[error] 18 | return {
[error] 19 | query: "erpnext.projects.doctype.task.task.get_project"
[error] 20 | }
erpnext/public/js/utils/contact_address_quick_entry.js
erpnext/crm/doctype/appointment_booking_settings/appointment_booking_settings.js
erpnext/stock/doctype/packing_slip/packing_slip.js
erpnext/public/js/utils/item_selector.js
erpnext/projects/doctype/task/task_list.js
[error] erpnext/accounts/doctype/purchase_invoice/purchase_invoice_list.js: SyntaxError: Unexpected token (46:19)
[error] 44 | });
[error] 45 |
[error] > 46 | onload: function (listview) {
[error] | ^
[error] 47 | listview.page.add_action_item(__("Purchase Receipt"), () => {
[error] 48 | erpnext.bulk_transaction_processing.create(listview, "Purchase Invoice", "Purchase Receipt");
[error] 49 | });
erpnext/accounts/doctype/share_transfer/share_transfer.js
erpnext/accounts/doctype/purchase_taxes_and_charges_template/purchase_taxes_and_charges_template.js
erpnext/stock/doctype/material_request/material_request.js
erpnext/projects/doctype/project/project_list.js
erpnext/stock/doctype/purchase_receipt/purchase_receipt.js
[error] erpnext/setup/doctype/company/company.js: SyntaxError: Unexpected token (152:3)
[error] 150 | erpnext.company.set_chart_of_accounts_options(frm.doc);
[error] 151 |
[error] > 152 | },
[error] | ^
[error] 153 |
[error] 154 | make_default_tax_template: function (frm) {
[error] 155 | frm.call({
erpnext/selling/doctype/quotation/quotation.js
erpnext/crm/doctype/contract/contract_list.js
erpnext/selling/page/point_of_sale/pos_payment.js
erpnext/accounts/doctype/exchange_rate_revaluation/exchange_rate_revaluation.js
erpnext/crm/report/campaign_efficiency/campaign_efficiency.js
erpnext/manufacturing/doctype/bom/bom.js
erpnext/selling/page/point_of_sale/pos_item_selector.js
erpnext/quality_management/doctype/quality_procedure/quality_procedure_tree.js
erpnext/crm/report/lead_conversion_time/lead_conversion_time.js
erpnext/manufacturing/doctype/production_plan/production_plan_list.js
eslint...................................................................Failed
- hook id: eslint
- exit code: 1
erpnext/public/js/event.js
89:2 error Parsing error: Unexpected token }
✖ 1 problem (1 error, 0 warnings)
erpnext/accounts/doctype/subscription/subscription.js
123:3 error Parsing error: Unexpected token }
erpnext/public/js/utils.js
266:11 error 'existing_filter' is not defined no-undef
276:7 error 'existing_filter' is not defined no-undef
277:7 error 'existing_filter' is not defined no-undef
296:12 error 'found' is not defined no-undef
erpnext/support/doctype/issue/issue.js
6:9 error Parsing error: Unexpected token .
✖ 6 problems (6 errors, 0 warnings)
erpnext/accounts/doctype/pos_closing_entry/pos_closing_entry.js
159:3 error Parsing error: Unexpected token ,
erpnext/assets/doctype/asset/asset.js
270:3 error 'depr_schedule' is not defined no-undef
407:54 error 'depr_schedule' is not defined no-undef
erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js
43:1 error Parsing error: Unexpected token }
✖ 4 problems (4 errors, 0 warnings)
erpnext/setup/doctype/company/company.js
152:3 error Parsing error: Unexpected token ,
✖ 1 problem (1 error, 0 warnings)
erpnext/accounts/doctype/bank_transaction/bank_transaction.js
125:6 error Parsing error: Unsyntactic break
erpnext/accounts/doctype/sales_invoice/sales_invoice.js
1129:3 error 'calculate_down_payment' is not defined no-undef
1132:3 error 'calculate_down_payment' is not defined no-undef
1135:3 error 'calculate_down_payment' is not defined no-undef
erpnext/stock/doctype/purchase_receipt/purchase_receipt_list.js
40:10 error Parsing error: Unexpected token function
✖ 5 problems (5 errors, 0 warnings)
erpnext/projects/doctype/task/task.js
17:6 error Parsing error: Unexpected token .
✖ 1 problem (1 error, 0 warnings)
erpnext/accounts/doctype/purchase_invoice/purchase_invoice_list.js
46:10 error Parsing error: Unexpected token function
✖ 1 problem (1 error, 0 warnings)
Conflicts detected for source commit: f4d69f16c0fa9ec2a810535fc49194f3db79a07d
- DU commitlint.config.js
Cleaning files from denylist:
commitlint.config.js | 13 +++++++++++++
1 file changed, 13 insertions(+)
pre-commit failed for source commit: f4d69f16c0fa9ec2a810535fc49194f3db79a07d
prettier.................................................................Failed
- hook id: prettier
- exit code: 2
[error] erpnext/accounts/doctype/subscription/subscription.js: SyntaxError: Unexpected token, expected "," (123:3)
[error] 121 | });
[error] 122 | }
[error] > 123 | })
[error] | ^
[error] 124 | dialog.show()
[error] 125 | },
[error] 126 |
[error] erpnext/accounts/doctype/bank_transaction/bank_transaction.js: SyntaxError: Unexpected token (132:5)
[error] 130 | });
[error] 131 | break;
[error] > 132 | case "Purchase Invoice":
[error] | ^
[error] 133 | frappe.db.get_value(row.payment_document, row.payment_entry, ["is_return", "supplier", "due_date"], r => {
[error] 134 | frappe.model.set_value(cdt, cdn, "payment_type", r.is_return ? "Debit": "Credit");
[error] 135 | r&&r.supplier&&frappe.model.set_value(cdt, cdn, "party", r.supplier);
[error] erpnext/accounts/doctype/journal_entry/journal_entry.js: SyntaxError: Unexpected token (191:25)
[error] 189 | erpnext.accounts.dimensions.update_dimension(frm, frm.doctype);
[error] 190 |
[error] > 191 | voucher_type: function (frm) {
[error] | ^
[error] 192 | if (!frm.doc.company) return null;
[error] 193 |
[error] 194 | if (
[error] erpnext/public/js/event.js: SyntaxError: Unexpected token (76:1)
[error] 74 | );
[error] 75 | },
[error] > 76 | });
[error] | ^
[error] 77 |
[error] erpnext/accounts/doctype/payment_entry/payment_entry.js: SyntaxError: Unexpected token (599:45)
[error] 597 | );
[error] 598 |
[error] > 599 | set_account_currency_and_balance: function (
[error] | ^
[error] 600 | frm,
[error] 601 | account,
[error] 602 | currency_field,
prettier.................................................................Failed
- hook id: prettier
- exit code: 2
[error] erpnext/accounts/doctype/subscription/subscription.js: SyntaxError: Unexpected token, expected "," (123:3)
[error] 121 | });
[error] 122 | }
[error] > 123 | })
[error] | ^
[error] 124 | dialog.show()
[error] 125 | },
[error] 126 |
[error] erpnext/accounts/doctype/bank_transaction/bank_transaction.js: SyntaxError: Unexpected token (132:5)
[error] 130 | });
[error] 131 | break;
[error] > 132 | case "Purchase Invoice":
[error] | ^
[error] 133 | frappe.db.get_value(row.payment_document, row.payment_entry, ["is_return", "supplier", "due_date"], r => {
[error] 134 | frappe.model.set_value(cdt, cdn, "payment_type", r.is_return ? "Debit": "Credit");
[error] 135 | r&&r.supplier&&frappe.model.set_value(cdt, cdn, "party", r.supplier);
[error] erpnext/accounts/doctype/journal_entry/journal_entry.js: SyntaxError: Unexpected token (191:25)
[error] 189 | erpnext.accounts.dimensions.update_dimension(frm, frm.doctype);
[error] 190 |
[error] > 191 | voucher_type: function (frm) {
[error] | ^
[error] 192 | if (!frm.doc.company) return null;
[error] 193 |
[error] 194 | if (
[error] erpnext/public/js/event.js: SyntaxError: Unexpected token (76:1)
[error] 74 | );
[error] 75 | },
[error] > 76 | });
[error] | ^
[error] 77 |
[error] erpnext/accounts/doctype/payment_entry/payment_entry.js: SyntaxError: Unexpected token (599:45)
[error] 597 | );
[error] 598 |
[error] > 599 | set_account_currency_and_balance: function (
[error] | ^
[error] 600 | frm,
[error] 601 | account,
[error] 602 | currency_field,
eslint...................................................................Failed
- hook id: eslint
- exit code: 1
erpnext/accounts/doctype/bank_transaction/bank_transaction.js
131:6 error Parsing error: Unsyntactic break
erpnext/accounts/doctype/journal_entry/journal_entry.js
191:16 error Parsing error: Unexpected token function
erpnext/accounts/doctype/subscription/subscription.js
123:3 error Parsing error: Unexpected token }
✖ 3 problems (3 errors, 0 warnings)
erpnext/accounts/doctype/payment_entry/payment_entry.js
599:36 error Parsing error: Unexpected token function
erpnext/public/js/event.js
76:1 error Parsing error: Unexpected token }
✖ 2 problems (2 errors, 0 warnings)
Suspicious merge commit detected: f4d69f16c0fa9ec2a810535fc49194f3db79a07d
Suspicious changes found (dokos|telemetry|shipping_rule|capture_doc):
91d227b2cda2ff6d6a7972d81377bbeabb541e12 style: format js filesCheckout instructions
# Checkout locally
git fetch upstream
git switch ft-pr-40206
# Alternatively, re-take the changes
git switch develop
ft take ft-pr-40206
# Make changes then rebase
git rebase -i develop
# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue
# Force-push changes
git push --force-with-lease