feat: surface data import failures in log files [frappe] PR#40596

Bot Dokosrequested to merge
ft-pr-40596 into develop

From: https://github.com/frappe/frappe/pull/40596
Date: 2026-07-05 04:11:43+05:30

  • fix: make data import file logging best-effort
  • fix: record data import failure before logging to logger
  • test: assert data import row failure is logged
  • feat: log data import failures to frappe logger


Diagnostics

pre-commit failed for source commit: ec17d5399939896ead2b92a48290f0114992c288
RUF005 Consider `[row.row_number, *row.as_list()]` instead of concatenation
   --> frappe/core/doctype/data_import/importer.py:721:11
    |
719 |                 }
720 |
721 |         data = [[row.row_number] + row.as_list() for row in self.data]
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
722 |
723 |         tree_preview = self.get_tree_preview()
    |
help: Replace with `[row.row_number, *row.as_list()]`

Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).


pre-commit failed for source commit: efdd562f80fcfc4ebfe2a87a40622c7bdb9e1614
RUF005 Consider `[row.row_number, *row.as_list()]` instead of concatenation
   --> frappe/core/doctype/data_import/importer.py:722:11
    |
720 |                 }
721 |
722 |         data = [[row.row_number] + row.as_list() for row in self.data]
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
723 |
724 |         tree_preview = self.get_tree_preview()
    |
help: Replace with `[row.row_number, *row.as_list()]`

Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).


pre-commit failed for source commit: 754e099a2fec33510ae9432a3c941c92321c1aba
RUF005 Consider `[row.row_number, *row.as_list()]` instead of concatenation
   --> frappe/core/doctype/data_import/importer.py:728:11
    |
726 |                 }
727 |
728 |         data = [[row.row_number] + row.as_list() for row in self.data]
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
729 |
730 |         tree_preview = self.get_tree_preview()
    |
help: Replace with `[row.row_number, *row.as_list()]`

Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-40596

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-40596

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports