feat(listview): Move likes to the right, hide "-" empty assigments PR#22659
From: https://github.com/frappe/frappe/pull/22659
Date: 2023-10-13 15:40:34+05:30
- Merge pull request #22659 from barredterra/like-in-list
- refactor: redundant CSS/classes
- fix(listview): assigned to
- feat(listview): move likes to the right
Diagnostics
pre-commit failed for source commit: ca2e04d35d4e7de367830672c861fb75c5ed2b19
prettier.................................................................Failed
- hook id: prettier
- exit code: 2
[error] frappe/public/js/frappe/list/list_view.js: SyntaxError: Unexpected token, expected "," (1006:12)
[error] 1004 | ${frappe.utils.icon("es-line-chat-alt")}
[error] 1005 | ${doc._comment_count > 99 ? "99+" : doc._comment_count || 0}
[error] > 1006 | </span>`;
[error] | ^
[error] 1007 | }
[error] 1008 |
[error] 1009 | html += `
eslint...................................................................Failed
- hook id: eslint
- exit code: 1
frappe/public/js/frappe/list/list_view.js
1006:12 error Parsing error: Unexpected token ;
✖ 1 problem (1 error, 0 warnings)
pre-commit failed for source commit: 681364815d2db6f903178403dfe2d499d7a0dc0e
prettier.................................................................Failed
- hook id: prettier
- exit code: 2
[error] frappe/public/js/frappe/list/list_view.js: SyntaxError: Unexpected token, expected "," (1003:12)
[error] 1001 | ${frappe.utils.icon("es-line-chat-alt")}
[error] 1002 | ${doc._comment_count > 99 ? "99+" : doc._comment_count || 0}
[error] > 1003 | </span>`;
[error] | ^
[error] 1004 | }
[error] 1005 |
[error] 1006 | html += `
eslint...................................................................Failed
- hook id: eslint
- exit code: 1
frappe/public/js/frappe/list/list_view.js
1003:12 error Parsing error: Unexpected token ;
✖ 1 problem (1 error, 0 warnings)
pre-commit failed for source commit: ff0e3c73ad4979651469e71196f5413d0fc108bf
prettier.................................................................Failed
- hook id: prettier
- exit code: 2
[error] frappe/public/js/frappe/list/list_view.js: SyntaxError: Unexpected token, expected "," (1003:12)
[error] 1001 | ${frappe.utils.icon("es-line-chat-alt")}
[error] 1002 | ${doc._comment_count > 99 ? "99+" : doc._comment_count || 0}
[error] > 1003 | </span>`;
[error] | ^
[error] 1004 | }
[error] 1005 |
[error] 1006 | html += `
eslint...................................................................Failed
- hook id: eslint
- exit code: 1
frappe/public/js/frappe/list/list_view.js
1003:12 error Parsing error: Unexpected token ;
✖ 1 problem (1 error, 0 warnings)
Checkout instructions
# Checkout locally
git fetch upstream
git switch ft-pr-22659
# Make changes then rebase
git rebase -i upstream/develop --reapply-cherry-picks
# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue
# Force-push changes
git push --force-with-lease