refactor: get_linked_docs by gavindsouza [frappe] PR#26872

Bot Dokosrequested to merge
ft-pr-26872 into develop

From: https://github.com/frappe/frappe/pull/26872
Date: 2024-06-27 11:33:56+00:00

  • refactor: get_linked_docs


Diagnostics

pre-commit failed for source commit: cdacca91a6148a34d46a48b28ff0f044281f1c40
Run ruff linter..........................................................Failed
- hook id: ruff
- exit code: 1

frappe/desk/form/linked_with.py:137:19: RUF005 Consider `[*self.get_link_sources(), self.root_doctype]` instead of concatenation
frappe/desk/form/linked_with.py:152:44: RUF013 PEP 484 prohibits implicit `Optional`
frappe/desk/form/linked_with.py:159:26: RUF005 Consider `[*filters, ["parent", "in", tuple(doctypes)]]` instead of concatenation
frappe/desk/form/linked_with.py:160:29: RUF005 Consider `[*filters, ["dt", "in", tuple(doctypes)]]` instead of concatenation
frappe/desk/form/linked_with.py:187:15: RUF013 PEP 484 prohibits implicit `Optional`
frappe/desk/form/linked_with.py:187:54: RUF013 PEP 484 prohibits implicit `Optional`
frappe/desk/form/linked_with.py:224:15: RUF013 PEP 484 prohibits implicit `Optional`
frappe/desk/form/linked_with.py:224:54: RUF013 PEP 484 prohibits implicit `Optional`
frappe/desk/form/linked_with.py:264:15: RUF013 PEP 484 prohibits implicit `Optional`
frappe/desk/form/linked_with.py:264:54: RUF013 PEP 484 prohibits implicit `Optional`
frappe/desk/form/linked_with.py:322:18: RUF013 PEP 484 prohibits implicit `Optional`
Found 11 errors.
No fixes available (11 hidden fixes can be enabled with the `--unsafe-fixes` option).


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-26872

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-26872

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports