Skip to content

feat: Add new before_login hook by paurosello [frappe] PR#26394

Bot Dokos requested to merge ft-pr-26394 into develop

From: https://github.com/frappe/frappe/pull/26394
Date: 2024-05-13 10:11:06+02:00

  • feat: pre-login hook (#26394)


Diagnostics

pre-commit failed for source commit: c19e6a87329bf890d26dc667827807ae75374d03
Run ruff linter..........................................................Failed
- hook id: ruff
- exit code: 1

frappe/auth.py:228:31: RUF013 PEP 484 prohibits implicit `Optional`
frappe/auth.py:228:48: RUF013 PEP 484 prohibits implicit `Optional`
frappe/auth.py:497:14: RUF013 PEP 484 prohibits implicit `Optional`
Found 3 errors.
No fixes available (3 hidden fixes can be enabled with the `--unsafe-fixes` option).


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-26394

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-26394

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports