Skip to content

fix: pass user and shared params when checking for cache keys by nikkothari22 [frappe] PR#26402

Bot Dokos requested to merge ft-pr-26402 into develop

From: https://github.com/frappe/frappe/pull/26402
Date: 2024-05-10 18:18:43+05:30

  • fix: pass user and shared params when checking for cache keys (#26402)


Diagnostics

pre-commit failed for source commit: fb2753fcaf34506292dd8323cb00250cbf64a30f
Run ruff linter..........................................................Failed
- hook id: ruff
- exit code: 1

frappe/utils/caching.py:90:31: RUF013 PEP 484 prohibits implicit `Optional`
frappe/utils/caching.py:143:20: RUF013 PEP 484 prohibits implicit `Optional`
Found 2 errors.
No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option).


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-26402

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-26402

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports