Skip to content

fix: cache github release data per bench by ankush [frappe] PR#26382

Bot Dokos requested to merge ft-pr-26382 into develop

From: https://github.com/frappe/frappe/pull/26382
Date: 2024-05-09 12:22:39+05:30

  • fix: cache github release data per bench (#26382)


Diagnostics

pre-commit failed for source commit: c2d5ef175c57078e1a192506d4b1d9de0629f608
Run ruff linter..........................................................Failed
- hook id: ruff
- exit code: 1

frappe/utils/caching.py:90:31: RUF013 PEP 484 prohibits implicit `Optional`
frappe/utils/caching.py:142:20: RUF013 PEP 484 prohibits implicit `Optional`
frappe/utils/change_log.py:244:68: F821 Undefined name `current_version`
frappe/utils/change_log.py:258:9: F821 Undefined name `suppress`
frappe/utils/change_log.py:259:24: F821 Undefined name `SimpleSpec`
Found 5 errors.
No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option).




Suspicious changes found (dokos|telemetry|shipping_rule|capture_doc|sentry|marketplace_apps|subscription_conf):
  9028e16d22cf745aa10ef7653f0fa19dbf9169ed fix: cache github release data per bench (#26382)


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-26382

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-26382

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports