Skip to content

fix: link filter falsy fix by RitvikSardana [frappe] PR#26282

Bot Dokos requested to merge ft-pr-26282 into develop

From: https://github.com/frappe/frappe/pull/26282
Date: 2024-05-03 17:43:06+05:30

  • fix: link filter falsy fix (#26282)


Diagnostics

pre-commit failed for source commit: 5e25d2d121c0d9c4682c1441eb78fd95ad1d3cfa
prettier.................................................................Failed
- hook id: prettier
- exit code: 2

[error] frappe/public/js/frappe/form/controls/link.js: SyntaxError: Unexpected token, expected "," (758:3)
[error]   756 | 			filters.push([fieldname, operator, value]);
[error]   757 | 		}
[error] > 758 | 		return filters;
[error]       | 		^
[error]   759 | 	}
[error]   760 |
[error]   761 | 	validate(value) {

eslint...................................................................Failed
- hook id: eslint
- exit code: 1

frappe/public/js/frappe/form/controls/link.js
  758:3  error  Parsing error: Unexpected token return

✖ 1 problem (1 error, 0 warnings)




Suspicious changes found (dokos|telemetry|shipping_rule|capture_doc|sentry|marketplace_apps|subscription_conf):
  5ac6e96948653a51033763096362652397ca0a00 fix: link filter falsy fix (#26282)


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-26282

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-26282

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports