Skip to content

feat: limit oauth client to roles by ankush [frappe] PR#26193

Bot Dokos requested to merge ft-pr-26193 into develop

From: https://github.com/frappe/frappe/pull/26193
Date: 2024-04-29 12:09:26+05:30

  • feat: Limit OAuth Client by roles
  • fix(UX): bulk delete error messages


Diagnostics

pre-commit failed for source commit: 926c888374132cf9bda6a128d64edbe05cfa6d5a
Run ruff linter..........................................................Failed
- hook id: ruff
- exit code: 1

frappe/desk/reportview.py:390:10: RUF005 Consider `[_("Sr"), *get_labels(db_query.fields, doctype)]` instead of concatenation
frappe/desk/reportview.py:391:14: RUF005 Consider `[i + 1, *list(row)]` instead of concatenation
frappe/desk/reportview.py:585:13: RUF005 Consider `[*filters, [column, "!=", ""]]` instead of concatenation
frappe/desk/reportview.py:596:14: RUF005 Consider `[*filters, [column, "in", ("", ",")]]` instead of concatenation
frappe/desk/reportview.py:635:13: RUF005 Consider `[*filters, "ifnull(`%s`,'')!=''" % tag["name"]]` instead of concatenation
frappe/desk/reportview.py:657:15: RUF005 Consider iterable unpacking instead of concatenation
Found 6 errors.
No fixes available (6 hidden fixes can be enabled with the `--unsafe-fixes` option).


pre-commit failed for source commit: ae4eb8745824dcd86bc943f23d01156258d78a27
Run ruff linter..........................................................Failed
- hook id: ruff
- exit code: 1

frappe/core/doctype/user/user.py:917:56: RUF013 PEP 484 prohibits implicit `Optional`
frappe/core/doctype/user/user.py:917:82: RUF013 PEP 484 prohibits implicit `Optional`
frappe/core/doctype/user/user.py:1294:28: RUF005 Consider `[warning, *suggestions]` instead of concatenation
Found 3 errors.
No fixes available (3 hidden fixes can be enabled with the `--unsafe-fixes` option).


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-26193

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-26193

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports