Skip to content

fix: bigint validation by ankush [frappe] PR#25733

Bot Dokos requested to merge ft-pr-25733 into develop

From: https://github.com/frappe/frappe/pull/25733
Date: 2024-04-06 10:45:50+05:30

  • refactor!: Better Integer handling
  • fix(DX): annotate chainable methods with Self return
  • fix: invlaid integer validations for biging


Diagnostics

pre-commit failed for source commit: 30f00fd5f3ffba649a1f959ec7a8a75fb89b1f74
Run ruff linter and apply fixes..........................................Failed
- hook id: ruff
- exit code: 1

frappe/model/base_document.py:621:5: RUF005 Consider `[*list(d.values()), name]` instead of concatenation
Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-25733

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-25733

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports