Skip to content

fix: allow disabling logging on CRON jobs by ankush [frappe] PR#25742

Bot Dokos requested to merge ft-pr-25742 into develop

From: https://github.com/frappe/frappe/pull/25742
Date: 2024-03-30 11:51:56+05:30

  • fix: allow disabling logging on CRON jobs (#25742)


Diagnostics

pre-commit failed for source commit: 561617d5db30a6deef87f7ab08dbf60e5c624fa5
Run ruff linter and apply fixes..........................................Failed
- hook id: ruff
- exit code: 1

frappe/core/doctype/scheduled_job_type/scheduled_job_type.py:200:22: RUF013 PEP 484 prohibits implicit `Optional`
frappe/core/doctype/scheduled_job_type/scheduled_job_type.py:237:66: RUF013 PEP 484 prohibits implicit `Optional`
Found 2 errors.
No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option).


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-25742

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-25742

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports