Skip to content

fix: sql_ddl -> commit directly by ankush [frappe] PR#25704

Bot Dokos requested to merge ft-pr-25704 into develop

From: https://github.com/frappe/frappe/pull/25704
Date: 2024-03-28 18:43:55+05:30

  • fix: sql_ddl - always ensure commit (#25704)


Diagnostics

pre-commit failed for source commit: be579f9a8da3d968884d6f0e4b921c735163dede
Run ruff linter and apply fixes..........................................Failed
- hook id: ruff
- exit code: 1

frappe/database/database.py:60:21: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
frappe/database/database.py:61:22: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
frappe/database/database.py:63:20: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
Found 3 errors.


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-25704

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-25704

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports