Skip to content

fix: incorrect status on data import by uhrjun [frappe] PR#25660

Bot Dokos requested to merge ft-pr-25660 into develop

From: https://github.com/frappe/frappe/pull/25660
Date: 2024-03-28 15:24:29+05:30

  • fix: erase logs in case of complete failure
  • fix(importer): set Pending status as a fallback
  • fix: Correct logic for comlete success
  • fix: incorrect status on data import


Diagnostics

pre-commit failed for source commit: f75dd9d1ebb8f3cf55d5cac1192c84648606c081
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing frappe/core/doctype/data_import/importer.py

Run ruff linter and apply fixes..........................................Failed
- hook id: ruff
- exit code: 1

frappe/core/doctype/data_import/importer.py:492:11: RUF005 Consider `[row.row_number, *row.as_list()]` instead of concatenation
Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).


pre-commit failed for source commit: f22120190d28241aac963df291de1db8bb04b7f1
Run ruff linter and apply fixes..........................................Failed
- hook id: ruff
- exit code: 1

frappe/core/doctype/data_import/importer.py:492:11: RUF005 Consider `[row.row_number, *row.as_list()]` instead of concatenation
Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).


pre-commit failed for source commit: 2710c288707171b9e1c04ca19bf1958e5bbc98d6
Run ruff linter and apply fixes..........................................Failed
- hook id: ruff
- exit code: 1

frappe/core/doctype/data_import/importer.py:494:11: RUF005 Consider `[row.row_number, *row.as_list()]` instead of concatenation
Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).


pre-commit failed for source commit: 9f7c385b112c26a36860deb7c457e627baafb700
Run ruff linter and apply fixes..........................................Failed
- hook id: ruff
- exit code: 1

frappe/core/doctype/data_import/importer.py:498:11: RUF005 Consider `[row.row_number, *row.as_list()]` instead of concatenation
Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-25660

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-25660

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports