Skip to content

fix: Use CssParser to correctly pass options to wkhtmltopdf by marination [frappe] PR#25659

Bot Dokos requested to merge ft-pr-25659 into develop

From: https://github.com/frappe/frappe/pull/25659
Date: 2024-03-27 12:00:49+01:00

  • chore: Use dict comprehension instead of nested loops
  • chore: Test valid options extraction
  • fix: Use CssParser to correctly pass options to wkhtmltopdf


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-25659

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-25659

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports