Skip to content

feat: add eval support for link field filters by RitvikSardana [frappe] PR#25453

Bot Dokos requested to merge ft-pr-25453 into develop

conflicts with !2416 (merged)

don't forget to squash

From: https://github.com/frappe/frappe/pull/25453
Date: 2024-03-22 01:03:02+05:30

  • chore: code cleanup
  • chore: code cleanup
  • fix: eval support for child table
  • fix: support for adding filters for child table
  • feat: add eval support for link field filters



Diagnostics

pre-commit failed for source commit: 237572c7fbd0cbb252232f59b1686e5c3eb52a74
eslint...................................................................Failed
- hook id: eslint
- exit code: 1

frappe/public/js/frappe/form/controls/link.js
  860:2  error  Duplicate name 'parse_filters'  no-dupe-class-members

 1 problem (1 error, 0 warnings)


pre-commit failed for source commit: d3981107a3e05bc5d4d73acf75b56c6d2c110ae7
eslint...................................................................Failed
- hook id: eslint
- exit code: 1

frappe/public/js/frappe/form/controls/link.js
  859:2  error  Duplicate name 'parse_filters'  no-dupe-class-members

 1 problem (1 error, 0 warnings)



Checkout instructions
# Checkout locally
git fetch upstream
git switch ft-pr-25453

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-25453

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease
Edited by Corentin Forler

Merge request reports