Skip to content

fix: Use doctype setting to set auto-extracted file as private by marination [frappe] PR#24828

Bot Dokos requested to merge ft-pr-24828 into develop

From: https://github.com/frappe/frappe/pull/24828
Date: 2024-02-13 13:14:22+05:30

  • fix: Use regex in failing test
  • test: Comment + Comm.n file extraction & Attachments default to public for Communication
  • test: use meta for fetching settings
  • fix: Use doctype setting to set auto-extracted file as private


Diagnostics

pre-commit failed for source commit: 7445de9b1c101ea57e13944a852e529189f4085b
Run ruff linter and apply fixes..........................................Failed
- hook id: ruff
- exit code: 1

frappe/core/doctype/file/utils.py:172:48: RUF013 PEP 484 prohibits implicit `Optional`
frappe/core/doctype/file/utils.py:172:66: RUF013 PEP 484 prohibits implicit `Optional`
frappe/core/doctype/file/utils.py:279:39: RUF013 PEP 484 prohibits implicit `Optional`
frappe/core/doctype/file/utils.py:416:39: RUF013 PEP 484 prohibits implicit `Optional`
Found 4 errors.
No fixes available (4 hidden fixes can be enabled with the `--unsafe-fixes` option).


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-24828

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-24828

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports