Skip to content

perf: reduce import overhead on background jobs by ankush [frappe] PR#25459

Bot Dokos requested to merge ft-pr-25459 into develop

From: https://github.com/frappe/frappe/pull/25459
Date: 2024-03-15 11:43:36+05:30

  • Merge pull request #25459 from ankush/post_hog_memory_hog
  • perf: import sentinal locally
  • perf: preload modules in worker pool
  • perf: avoid importing posthog if not required


Diagnostics

pre-commit failed for source commit: b6f65eaff73f55d7e5c1f56759eb1b14daf499df
Run ruff linter and apply fixes..........................................Failed
- hook id: ruff
- exit code: 1

frappe/utils/telemetry.py:18:6: F821 Undefined name `Posthog`
frappe/utils/telemetry.py:18:24: F821 Undefined name `frappe`
frappe/utils/telemetry.py:19:7: F821 Undefined name `suppress`
frappe/utils/telemetry.py:20:33: F821 Undefined name `frappe`
Found 4 errors.


Suspicious merge commit detected: b6f65eaff73f55d7e5c1f56759eb1b14daf499df


Suspicious changes found (dokos|telemetry|shipping_rule|capture_doc):
  7211080dce606fc03a4b151b86b318c5189c3d5f Merge pull request #25459 from ankush/post_hog_memory_hog
  dc6270631211205ac6e7baac3edafc1dfd2e00f9 perf: avoid importing posthog if not required


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-25459

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-25459

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports