Skip to content

Minor Fixes and Housekeeping

Dian Fay requested to merge github/fork/xivSolutions/master into master

Created by: xivSolutions

There are a bunch of small, mostly minor commits here, and you may not want all of them. It appears some functionality was broken when the table stuff was moved into its own module. I created a fix that got most of the tests passing again by adding a Db parameter to the constructor of the Query module (it was not possible to execute arbitrary SQL using the "run" method without this, or a more substantial structural change. I'm not ready to do that yet ;-)).

I also fixed a few other things I ran into, and created test suites for the "table" module for each flavor of Db. These are pretty duplicative of the tests in the Query module, but it seems like each of the modules should be tested, no?

My goal was to learn my way around, fix some small stuff, and basically get all the tests passing and restore all the existing functionality.

Let me know if you want me to change any of this stuff up (if you find it remotely useful), or if it is of no use at all.

I have some ideas for some other structural stuff, but I'm not sure I trust my Node thinking cap yet.

Merge request reports