Rename constraint_relaxation to violation_relaxation
The "constraint_relaxation" name was confusing, as the relaxation was only indirectly applied to the eventual hard constraint (i.e. it was scaled by the goal's function nominal as well). The term violation_relaxation much better describes how this relaxation is applied.
-- NOTE A previous recommendation was epsilon_relaxation. The name epsilon is however not used in the docs at all, so that would have been confusing. The docs talk about a "violation variable" and "the violation", which was the deciding factor for picking "violation_relaxation" over "epsilon_relaxation".
The renaming to something more appropriate is one thing, but it's also about opening up the name constraint_relaxation
for future use. Then it will be directly applied to the constraints that are generated, without any scaling.
-
Rename epsilon_relaxation to violation_relaxation.