Skip to content

Resolve confusion in the admin view about which accounts had their password reset and which didn't

The list of users in the admin view has a column “Password reset” which is currently showing “Yes” for users who have their own password set and “No” for those who have a temporary password (e.g. password has actually been reset). The same confusion continues if you go to the password printout view: users who have their own password set (i.e. no temporary password exists) are displayed with “Temporary password.” This had me so confused that I almost filed an issue about the printout view resetting passwords without even asking for confirmation, and I only realized what’s going on here after looking at the source code.

It seems that the code is correct here even though columnHasSetPassword is somewhat confusing as a name. Merely the localized strings are wrong, I’ve adjusted these to match reality.

Merge request reports