Skip to content

Draft: feat: Small refactor events api

Gabriel Nützi requested to merge feat/small-refactor-events-api into develop

This PR occured only when looking through code and to not forget the findings.

This is a PR to showcase how a main function should look like and is open for discussion to sensibilize for the future and further clean up actions:

  • Glueing statements together to syntactically distinguish it from other parts is not so good. There is actually a language feature for that: functions =).
  • Panicing without logging is not such a good idea. So before panic, there must be a log statement. That is however best addressed more globally for the whole custodian to streamline into every service: custodian-go as the common library.
  • When we write log statements we should actually stick to writting proper english. Full sentences with full stop. No matter the error level.

This MR is only for discussion, you can merge it if it builds.

P.S: We need a PR template etc, etc.

Merge request reports