Skip to content

Update dict_merge to allow falsey config values

bduncan137 requested to merge bduncan137/gila:patch-1 into develop

Config values that are falsey (for example False, 0, etc) did not behave as expected.

return dict((key, dict_1.get(key) or dict_2.get(key))
                for key in keys)

In the code above, if dict_1.get(key) evaluates to False, dict2's value will win. This seems not to be expected behavior.

Merge request reports