Skip to content

Add aap/aap2 tools to the python-ud3tn-utils package

Maximilian Nitsch requested to merge feature/move-aap-tools into master

Description

  • Migrates from setup.py to pyproject.toml
  • Moves tools/aap + tools/aap2 to python-ud3tn-utils/aap*/bin/ to add the scripts to the python package
  • Adds a main() function to each script to reference it
  • Define logger as global variable
  • Adds a symbolic link to keep compatibility with existing tooling
  • Moves tools/aap/aap_test.py to test/functional/
  • Adds additional dependencies (pyd3tn, cbor) to python-ud3tn-utils and the corresponding nix package
  • Add scripts to python-ud3tn-utils pyproject.toml
  • Changes all occurrences of the old script paths from tools/ to the scripts installed by python-ud3tn-utils
  • Reuse the run_aap_recv() function from the python-ud3tn-utils package in the test/functional/sqlite_storage_test/storage_agent_bundle_id_test.py instead of copying the code

Closes: #63 (closed)

Checklist for MR author

  • ✅ This MR does not introduce backwards-incompatible API changes.

  • ✅ This MR does not introduce new functionality without corresponding tests. It does not break or disable existing tests.

  • ✅ I am not aware of new interactions that could be prone to race conditions.

  • ✅ I have no security related reservations or thoughts I would like to share about the changes introduced by this MR.

  • ✅ The documentation (architecture, developer, operator, user) is in line with the changes in the MR.

  • ✅ My contribution adheres to the Contribution Guidelines. Specifically:

    • I provide my contribution under the terms and conditions of the Apache 2.0 license. I am aware of the patent grant that is part of this license and certify conformance.
    • I certify conformance with the DCO. All commits contain the corresponding signoff line.
    • I am aware that my contribution will become part of µD3TN, which is currently dual-licensed under AGPLv3 and a proprietary license offered by D3TN, and may potentially become part of software using other compatible licensing schemes in the future.

Checklist for MR reviewers

Note: Approving the MR is equivalent to confirming all items below.

  • I reviewed the changes.
  • I reviewed the commits.
  • I reviewed the statements made above; they are correct as far as I can judge. I have nothing to criticize.
  • New code in core components has good testability.
  • I reviewed the related Issue(s). The stated tasks have been addressed and the changes reflect the issue decisions.
Edited by Felix Walter

Merge request reports