Add licenses and docs in v4/ too

Hello,

could you add GO-LICENSE LICENSE README.md AUTHORS CONTRIBUTORS to v4 too?

Thanks.

@eclipseo Thanks for asking!

I'm not sure. Maybe the correct thing to do is the opposite - consolidate all AUTHORS and CONTRIBUTORS to the repository root. The same for license files.

WDYT?

For example, the last change to CONTRIBUTORS here: a50a00a5 went to the repo root without me even noticing/realizing there exist multiple versions.

If this is is the same for every version, sure.

We are doing some shenanigans when packaging for Fedora, separating all versions:

find . ! \( -name v2 -o -name _build -o -name AUTHORS -o -name CONTRIBUTORS -o -name GO-LICENSE -o -name LICENSE \) -maxdepth 1 -exec rm -rvf {} \;
mv v2/* .

Having something consistent would be nice.

If you're fine with the idea of merging all the files in question to the repo root: I can do that or you can send a MR if you prefer.

Wrt to packaging different versions: cc/v3 is more or less usable, but I personally consider cc/v4 the only version worth packaging. (v5 is a different story, it's @dennwc's fork of v4, but in the same repo.)

However, cc/v4 is nowadays being updated several times a week. Not sure if that plays well with packaging.

Out of curiosity: How does packaging of Go packages work? When someone does import modernc.org/cc/v4 does the go tool on Fedora first look for the locally installed distro package, if any?

We're still using GOPATH. We always look for the package installed by the distro, nowhere else.

Ok, that explains it. Thanks.

mentioned in commit 210473ee

mentioned in merge request !151 (merged)

@eclipseo PTAL @ !151 (merged).

closed with merge request !151 (merged)