Skip to content

Fix for AE sheet incorrectly registering flags due to misplaced quote character

jalensailin requested to merge jalenml-fix-AE-sheet into dev

Intent

MR !889 (merged) accidentally overcorrected and put quotes around handlebars logic that came after an attribute, rather than the attribute itself. This caused flags to register incorrectly.

This MR fixes that newly introduced bug.

  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal, there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Steps to Test

  1. On Dev, see that clicking the Situational checkbox on a change in an Active Effect doesn't work as intended.
  2. Switch to this branch.
  3. Clicking Situational checkbox works as intended.

Future Work

The test that checks if attributes are quotes may need rewriting if this MR fails the pipeline (or logic needs rearranging in the offending .hbs file). The test passed, no rewriting or rearranging needed.

Edited by jalensailin

Merge request reports