Skip to content

move eslint global ignores to eslint config file

jalensailin requested to merge jalenml/move-eslint-globals-to-config into master

Intent

Currently we add eslint ignore variables at the top of every js file, when we could define these in the eslint config file. This way, we don't repeat ourselves ignoring the same common variables all the time.

This MR removes the per-file ignores and adds the corresponding variables to the eslint config file (.eslintrc.json).

  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal; there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Steps to Test

  1. Passes ESLint test

Merge request reports