Skip to content

Change critEffectFail to only show for poor quality weapons on item sheet

Ryan Walder requested to merge ryanw/poor-quality-sheet into master

Intent

Change critEffectFail to only show for poor quality weapons on item sheet.

Also fix the ordering of the itemQuality key in the config so it defaults to standard.

Before After
Peek_2024-04-27_12-36 Peek_2024-04-27_12-34

  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal; there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Related Issues

Steps to Test

  1. Checkout / Build / Load
  2. Create Attackable Item
  3. Set Quality to Poor
  4. Critical Fail Effect field shows
  5. Change to Standard/Excellent quality
  6. Critical Fail Effect field disappears

Merge request reports