Skip to content

Fix roll processing to accept lowercase and upper case roll formulas

Ryan Walder requested to merge ryanw/fix-capitalized-rolls into master

Intent

Allow rolls to be lower or uppercase to be more robust EG: 1d6 or 1D6

  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal; there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Related Issues

  • 975 (not linked on purpose so it doesn't get closed on merge)

Steps to Test

  1. Checkout / Build / Load master
  2. Create Weapon damage with uppercase roll eg: 1D6
  3. Throws error/does not roll
  4. Checkout / Build / Load
  5. Roll previously created weapon damage
  6. No Error, Rolls as expected
  7. Do the same for custom ammo with a damage override

Merge request reports