Skip to content

Refactor how we handle brand names

Ryan Walder requested to merge ryanw/brand-names into master

Intent

As per #940 the way we implemented brand names for items caused more problems than it solved. This MR keeps the brand datapoint and pill on the item sheet but ensures all items are named how they are in the source books (for better or worse). This solves problems with sorting, searching etc.

Wiki docs also updated to follow this new process.

Also fix a load of JSONSchemas that needed updating.

Note: Do not merge this without notifying #Translation in Discord as this will trigger a lot of re-translations. The item names will need re-translation, the descriptions should be handled by translation memory.

  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal; there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Related Issues

Steps to Test

Foundry:

  1. Checkout / Build / Load
  2. Find some Branded items in the compendia
  3. See they are named the same as in the books (for better or worse)
  4. Add them to actor sheets to check they display corectly

Wiki:

  1. Read the Items/Item Brands docs
Edited by Ryan Walder

Merge request reports