Skip to content

Fix NET Arch Generation when using custom paths

Ryan Walder requested to merge ryanw/fix-netarch-gen-images into master

Intent

When generating a NET Arch with custom images if you didn't add a / to the end of the path to the images it would fail to load, this was the default behaviour of the filepicker. This makes the code more robust and works with or without the / at the end of the path.

Also refactors the NET arch Generation template to remove unneeded <span>s and <hr>s, rewords some strings.

  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal; there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Related Issues

Steps to Test

  1. Download/Extract netarch-bw.zip tiles somewhere Foundry can access (or create your own custom tiles, these are just the system ones made B&W fo ease of checking stuff is working
  2. Checkout/Build/Load
  3. Create NET Arch item
  4. Generate a NET Arch from Rolltables on the item
  5. Generate a Scene from the item using custom tiles
    • Do not add a / to the path to your tiles
  6. Delete Scene
  7. Generate a Scene from the item using custom tiles
    • Add a / to the path of your tiles
  8. Delete Scene
  9. Generate scene from the item using default tiles

Additional Notes

Old Dialog New Dialog
image image

Merge request reports