Skip to content

Modify track behavior from item sheet

Norman Briggs requested to merge cruxis/armor_SP_bar_improvements_235 into master

Intent

Intent is to allow the player to modify tracked stats from the item sheet directly when updating body/head armor ablation/sp values and to do the same for shield current/max values.

  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal; there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Note: Requires !1251 (merged) to be merged first

Related Issues

Steps to Test

  1. Checkout/build
  2. Create new actor, assign one each of head, body and shield armor items
  3. Cycle each to equipped state, observe that star is auto-filled on equip to indicate it is currently tracked.
  4. Assign externalData point for shield, head and body armor on actor bar, observe that actor bar displays correct SP/ablation for equipped armor
  5. Go to item sheet for each shield, head and body that have been equipped and observe that when changed, the change is reflected on the character bar when the sheet is closed (currently tabbing off of the field is not firing the listener, will need to manually click another field when adjusted). Do this for each item type for each bar.

Future Work

Currently no check for determining if armor SP/ablation values have been swapped (i.e., no check to determine if ablation is higher than sp value, same for shield current/max) and behavior of auto-tracking equipped armor may be undesired; if so, can deprecate this change.

Additional Notes

None

Edited by Ryan Walder

Merge request reports