Skip to content

Add type field to skill data model

Ryan Walder requested to merge ryanw/hardened-actual into master

Intent

  • Add skillType field to skill datamodel
    • We need to identify certain types of skill across languages, this can't be done by simple text matching so this adds a field to determine the type of skill it is so we can grab it programmatically
      • Language
      • Science
      • Martial Art
      • Play Instrument
  • Update Internal/Skills
    • Remove:
      • Science
      • Play Instrument
      • Martial Arts
    • Rename Local Expert > Local Expert (Your Home)
  • Update Core/Skills (Language)
    • Add new skillType data point to all skills
  • Add new packs for Skill that should have been typed skills using the examples from the book
    • Core/Skills (Science)
    • Core/Skills (Martial Arts)
    • Core/Skills (Play Instrument)
  • Add Babele translation files for the new packs
  • Update JSONSchema (and relevant packs) to delete
    • description:unidentified
    • description:chat
    • Should have been done as part of the data schema work

  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal; there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Related Issues

Steps to Test

  1. Checkout/Build/Load
  2. Check Core: Skills (*) Compendia are as expected
  3. Create new character
    • No Science, Play Instrument, Martial Arts Skills
    • Local Expert is called Local Expert (Your Home)
Edited by Ryan Walder

Merge request reports