Skip to content

Compendia Updates from Issue 933

Norman Briggs requested to merge cruxis/compendia_updates_933 into hotfix-0.88.3

Intent

  • Fix numerous compendium issues in #933
  • Refine cleanPack function
    • Remove nbsp
    • Convert duplicate <br> into </p><p>
    • Fix spacing on <strong></strong> instances
    • Fix other misc issues that come from the WYSISWYG editor in Foundry
  • Add a new step in gulp/utils/packUtils.mjs/cleanPacks to run Prettier on Item Descriptions
    • Should be more consistent across runs leading to less phantom changes
    • Give cleaner strings for translations
    • Make diffs cleaner/easier to read

  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal; there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Related Issues

Steps to Test

  1. Checkout and build
  2. Check each compendia change by commit, should be obvious from the code change, I'll provide specific instructions if needed.

Future Work

This will need a decent amount of work from translators as basically every description has been upgraded in some way. I'm hoping much of this will be handled by Crowdin as it hopefully rememberers the string themselves and can work around the html/structure changes. We may need to use the Translation Memory. We will see once this is merged into the hotfix branch.

Additional Notes

At Twig's recommendation, will try and publish this by change, may wrap two or three changes together if convenient.

Edited by Ryan Walder

Merge request reports