Skip to content

Enable Support for DDDice

Jay Greguske requested to merge zyzyx-issue-653 into master

Intent

Enable support for the DDDice module, which is another 3d dice rolling module but with more online features. This code will prefer dice-so-nice if both are installed.

See #653 (closed) for more background. The original request was more prescriptive until we explained why we roll dice the way we do and why we have custom chat cards. Make sure you follow the comments in that issue to understand this MR.


  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal; there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Related Issues

Steps to Test

  1. Install Dice-So-Nice (DSN) and DDDice modules to Foundry.
  2. Load up a world, and enable DDDice. Make sure DSN is disabled. Make some rolls from a sheet and with the /red command. You should see DDDice rendering.
  3. Unload DDDice and load DSN in the world using the module configuration.
  4. Make some rolls from a sheet and with the /red command. Confirm DSN renders like usual.
  5. Enable both DDDice and DSN.
  6. Make some rolls from a sheet and with the /red command. Confirm DSN renders like usual.

Future Work

I don't have a way to confirm that the DDDice APIs are being hit properly when DSN is doing the rendering. I can fire up wireshark to watch packets but there is probably a better way. It is possible Celeste comes back with more work for us to integrate better once this is out.

Edited by Jay Greguske

Merge request reports