Add Quality & critFailEffect data points
Intent
Add the Quality
datapoint back to Cyberdeck
/Weapon
items.
I did a "best effort" migration (via gulp/extractPacks, not system migration) for quality in pack items by checking the name
and description
for poor
/excellent
then setting it based on that (not all weapons/decks have (Poor)
/(Excellent)
in the name). These may not be 100% but I'm sure they will be shaken out over time.
critFailEffect
should be right for core/black chrome, there may be some DLC that still needs the correct value.
-
This is meant for a hotfix -
This is meant for the next release (see milestone) -
This needs more reviewers than normal; there may be controversy or high complexity -
This intentionally introduces regressions that will be addressed later -
There is/will be documentation changes on the wiki -
Please do not send commits here without coordinating closely with the owner -
This is a Build System change
Related Issues
Steps to Test
- Create new
Weapon
and/orCyberdeck
- Set
Quality
inSettings
- Set
Attack Critical Failure Effect
- Close/Re-open
-
Quality
/Attack Critical Failure Effect
is Saved - Can check in the exported json as well
Future Work
Neither of these data points are used in the system itself right now and are more informational for now. These should bot be added to roll data at some point for use by modules/the system, this will probably be done along with 849.
Migrations for user items see: 930