Skip to content

Fix DV table display in non-english languages

jalensailin requested to merge jalenml/add-dv-table-to-weapon-babele-translations into hotfix-0.88.2

Intent

See #902 (closed) for the issue and my long comment for the explanation of what is going on. It turns out that I overestimated the amount of work this would be to fix, having not yet delved into how the Babele files are generated. This was a good reason to look into that.

NOTE: I made it so that the generateBabele job adds a DV table field to relevant entries in the English Babele files, which should trigger Crowdin to automatically translate the new entries in other languages. These strings have been translated before so translators should not have extra work to do. Thus, after this is merged, we must wait for Crowdin to do it's thing and then merge that for the fix to truly work.

  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal; there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Related Issues

Steps to Test

Testing actually relies on Crowdin getting updated, which means testing can really only happen after this is merged and Crowdin catches up. That being said, you can test the fix by doing the following:

  1. Add the following to src/babele/es/cyberpunk-red-core.core_weapons.json:

image

  1. Open Foundry and switch your language to Spanish.
  2. Open an assault rifle from the weapon compendia ("Armas" in Spanish)
  3. Note that the DV table is correctly assigned.

Merge request reports