Skip to content

More CSS Fixes

Ryan Walder requested to merge ryanw/css-fixes into master

Intent

  • Fix Journal Sidebar color in defaut theme
  • Fix font color in compendium pop out
  • Fix CSS alignment for source/page in non-editable items
  • Harmonize styles for html tables between TinyMCE/Prosemirror and Markdown

  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal; there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Related Issues

Steps to Test

  1. Checkout / Build / Load
  2. Switch to Default theme
  3. Create Journal / Journal Pages
    • Can see the index of page on left hand side
  4. Open a Compendium so it pops out
    • All fonts have a readable color
  5. Open an Item from a compendium
  6. Got Item Settings tab
    • Source/Page should be aligned to right
  7. In a Journal page using Prosemirror/TinyMCE open the HTML editor and paste in the below HTML to create 3 tables (on generated by each Editor Engine)
  8. Save the HTML
    • All tables should be the same with the caveat that the bottom one starts with pink rather than white
<!-- TinyMCE -->

<table border="1">
  <colgroup>
    <col />
    <col />
    <col />
  </colgroup>
  <tbody>
    <tr>
      <td>Intensity</td>
      <td>Example</td>
      <td>Effect</td>
    </tr>
    <tr>
      <td><strong>Mild</strong></td>
      <td>Wood Fire / Incendary Ammo</td>
      <td>2 HP</td>
    </tr>
    <tr>
      <td><strong>Strong</strong></td>
      <td>Gasoline Fire</td>
      <td>4 HP</td>
    </tr>
    <tr>
      <td><strong>Deadly</strong></td>
      <td>Thermite</td>
      <td>6 HP</td>
    </tr>
  </tbody>
</table>

<!-- Prosemirror -->

<table>
  <tbody>
    <tr>
      <td><p>Intensity</p></td>
      <td><p>Example</p></td>
      <td><p>Effect</p></td>
    </tr>
    <tr>
      <td>
        <p><strong>Mild</strong></p>
      </td>
      <td><p>Wood Fire / Incendary Ammo</p></td>
      <td><p>2 HP</p></td>
    </tr>
    <tr>
      <td>
        <p><strong>Strong</strong></p>
      </td>
      <td><p>Gasoline Fire</p></td>
      <td><p>4 HP</p></td>
    </tr>
    <tr>
      <td>
        <p><strong>Deadly</strong></p>
      </td>
      <td><p>Thermite</p></td>
      <td><p>6 HP</p></td>
    </tr>
  </tbody>
</table>

<!-- Markdown -->

<table>
  <thead>
    <tr>
      <th id="intensity">Intensity</th>
      <th id="example">Example</th>
      <th id="effect">Effect</th>
    </tr>
  </thead>
  <tbody>
    <tr>
      <td><strong>Mild</strong></td>
      <td>Wood Fire / Incendiary Ammo</td>
      <td>2 HP</td>
    </tr>
    <tr>
      <td><strong>Strong</strong></td>
      <td>Gasoline Fire</td>
      <td>4 HP</td>
    </tr>
    <tr>
      <td><strong>Deadly</strong></td>
      <td>Thermite</td>
      <td>6 HP</td>
    </tr>
  </tbody>
</table>
Edited by Ryan Walder

Merge request reports