Skip to content

Fix Roll Card scaling with Font Size scaling

Ryan Walder requested to merge ryanw/fix-roll-card-scaling into hotfix-v0.87.4

Intent

Roll cards were using rem for sizing, this broke when adjusting Font Size in Foundry. This changes them to use fr to resize gracefully.

  • This is meant for a hotfix
  • This is meant for the next release (see milestone)
  • This needs more reviewers than normal; there may be controversy or high complexity
  • This intentionally introduces regressions that will be addressed later
  • There is/will be documentation changes on the wiki
  • Please do not send commits here without coordinating closely with the owner
  • This is a Build System change

Related Issues

Steps to Test

  1. Checkout / Build / Load
  2. Change Font Size to > 5
  3. Roll some skills till you get a crit
  4. Roll some damage
    • Roll card should be legible if a little wonky

Future Work

#849 to rewrite the rollcards, can tackle Larger Font Sizes during that

Additional Notes

While a little wonky this does make the rolls readable for those using a higher font size

Edited by Ryan Walder

Merge request reports