Skip to content

Added method to CR class for getting PointMaps of inner functions

Grant Bruer requested to merge gbruer/cr-build-inner-point-maps into main

This MR gives easy access to each of the four functions used to the compute the CR output. Having access to the scalar invariant point map and the inner function point map makes it much easier to visualize a CR's performance.

CR.__call__ takes inputs (input tensors) and optionally params (parameters). Then it calls the following four functions to get the full CR output:

  1. The scalar invariant function computes the scalar invariants as a function of inputs.
  2. The form invariant function computes the form-invariant basis as a function of inputs.
  3. The inner function computes the basis coefficients as a function of the scalar invariants and params.
  4. The coefficient form function computes the CR output using the basis coefficients and the form-invariant basis.

@tisaac @jedbrown @DiffeoInvariant I've not sure if I've written the right names for each of these components in that list above. Did we decide on standard names to use for these? Particularly, "inner function" and "coefficient form function" don't sound descriptive enough to me.

I added tests for this MR, and I'm still working on an actual use case that would use these to facilitate plotting the inputs and outputs of the inner CR.

Merge request reports