Wrap steam_cmd in quotes to resolve conditional check stack-trace

Wout Bouckaertrequested to merge
bugfix/steam_cmd_server_page into dev

What does this MR do and why?

Wraps the steam_cmd conditional check in m_server_controls_list.html and server_controls_list.html with quotes. Previously, this conditional check would cause a stack-trace if a user without config permissions attempted to view the server page. This bug failed identification because users with superuser or with config permission would pass the left side of the if. The lazy evaluated or allowed those checks to pass.

Screenshots or screen recordings

Previous:

image.png

Resolved:

image.png

How to set up and validate locally

Previous version:

Create user without config permissions to a server. Navigating to the server should display a stack-trace.

Fixed:

User without config permissions to the server should be able to view the server page.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Have you checked this doesn't interfere/conflict/duplicate someone elses work?
  • Have you fully tested your changes?
  • Have you resolved any lint issues?
  • Have you assigned a reviewer?
  • Have you applied correct labels?
Edited by Wout Bouckaert

Merge request reports