Skip to content

Fix totp dict size changing on login

Andrewrequested to merge
bugfix/totp-login into dev

What does this MR do and why?

  • Fixes TOTP login failure when attempted codes TOTP dictionary size would change while iterating through. This would cause a login failure until crafty is restarted.

How to set up and validate locally

  1. Log into Crafty with TOTP
  2. Log out
  3. Wait at least 120 seconds
  4. Try logging in again.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Have you checked this doesn't interfere/conflict/duplicate someone elses work?
  • Have you fully tested your changes?
  • Have you resolved any lint issues?
  • Have you assigned a reviewer?
  • Have you applied correct labels?

Merge request reports